- last update
over 1 year ago Patch Failed to Apply - πΊπΈUnited States dcam
I get that this is a problem, but I don't like the solution as it is. What do you think about having a setting to toggle this so that site builders can choose to do it or not? Even that would be a problem with the current solution since parser plugins don't have configuration forms. It would have to be moved to the processor plugin, which doesn't necessarily make sense.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 147 pass - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This is tagged needs tests, if we end up with a kernel test for the parser from other issues, this should be simpler to test
- last update
about 1 year ago 158 pass - last update
about 1 year ago 158 pass - πΊπΈUnited States dcam
I'm not going to bother with an interdiff. The underlying fix from the old patch is the same, but the implementation is totally different. I added a config setting to the parser for turning on future date normalization. Feel free to suggest a different term for it.
- πΊπΈUnited States dcam
Ok. Something is wrong here if the test-only patch passed.
- last update
about 1 year ago 162 pass - last update
about 1 year ago 158 pass, 1 fail - πΊπΈUnited States dcam
The test had the wrong namespace so it wasn't getting run at all. It turns out that I needed to include the schema file in the test patch though or it just throws "missing schema" errors without giving us a real result.
The last submitted patch, 39: 1420718-39-tests-only.patch, failed testing. View results β
- Status changed to RTBC
about 1 year ago 10:47pm 3 October 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Looks good to me.
To be honest I'd be happy without making this something you can configure from the UI but there's no harm now its done.
- Status changed to Needs review
about 1 year ago 12:07am 4 October 2023 - last update
about 1 year ago 162 pass - last update
about 1 year ago 162 pass - Status changed to Fixed
about 1 year ago 12:25am 4 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.