- First commit to issue fork.
- Merge request !7580Issue #1210940: No warning shown for undefined title callback function → (Open) created by apaderno
- last update
11 months ago 2,179 pass - First commit to issue fork.
- last update
11 months ago 2,155 pass, 33 fail - Status changed to Needs work
11 months ago 10:08pm 18 April 2024 - 🇸🇰Slovakia poker10
Thanks for working on this. I have added a simple test to see what this change means. The issue is a bit old and now PHP is doing more strict checks in various functions. Something it was previously a warning is now a TypeError, see the tests on PHP 8.1: https://git.drupalcode.org/project/drupal/-/jobs/1366920
I do not think that changing the current state (no error, no information about the mistake) to the proposed state (information via error) is a good idea. I think that maybe a simple watchdog message in case of undefined title callback will be a more viable solution. Thanks!
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Yes, new PHP versions throw an exception, instead of a PHP warning, but that happens also when the used page callback does not exist or it is not found. The MR I created made the behavior equal in the "title callback not existing or not found" and the "page callback not existing or not found", which I thought what this issue was trying to achieve.
I like better a logged message too, but I guess the same should be done also for page callbacks, which are invoked with
call_user_func_array()
. - last update
11 months ago run-tests.sh exception - Status changed to Needs review
11 months ago 8:16am 19 April 2024 - last update
11 months ago 2,179 pass - 🇮🇹Italy apaderno Brescia, 🇮🇹
The exception that causes run-tests.sh to fail is the following one.
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table "jenkins_drupal_d7_299361.simpletest106828cache_block" doesn't exist
It is not an exception caused by the MR's change.
- last update
11 months ago 2,180 pass