Remove truncation from parent menu

Open on Drupal.org →

Created on 23 May 2011, almost 14 years ago

Updated 15 January 2023, over 2 years ago

Problem/Motivation

When I add a new link in a menu and I select the parent link. The option list with the links appears truncated.

The function that truncate the title with a maximum of 30 characters is parentSelectOptionsTreeWalk in core/lib/Drupal/Core/Menu/MenuParentFormSelector.php. (Line 163)

$title = $indent . ' ' . Unicode::truncate($link->getTitle(), 30, TRUE, FALSE);

Does this limit exist for some special reason? And what would be the best way to override it?

Steps to reproduce

From #19

Steps to test -
1. Go to the admin site.
2. Go to admin/structure/menu/manage/admin/add?destination=/drupal9.1.x-dev/admin/structure/menu.
3. Create a menu link.
4. Again Go to admin/structure/menu/manage/admin/add?destination=/drupal9.1.x-dev/admin/structure/menu.
5. Verify the parent link field.

Proposed resolution

we should just remove the truncation altogether.

Before:

After:

Remaining tasks

Write tests

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

📌 Task

Status

Version

10.1 ✨

Component

Menu module →

Last updated about 1 month ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @pwolanin

Created by

🇪🇸Spain mordonez

Live updates comments and jobs are added and updated live.

Novice
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Incomplete comments

Sign in to follow issues

Merge Requests

!9077Remove truncation from parent menu
Open
🇧🇪Belgium kriboogh
updated 9 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs work over 2 years ago3:16am 16 January 2023
First commit to issue fork.
Merge request !9077Issue #1166282 by kriboogh: Remove truncation from parent menu → (Open) created by kriboogh
Pipeline finished with Success
9 months ago
Total: 547s
#244411
Comment 9 months ago →
🇧🇪Belgium kriboogh
Created MR from 56 and added a patch for composer use.
Applies to 11.x and 11.3.x.
Comment 7 months ago →
🇳🇴Norway steinmb
The MR is doing its thing correctly with a passing test. As the issue is still tagged with it needs we to pass a usability gate I feel I should not set it to RTBC, however, I think we are done in here.
Comment 7 months ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024