- 🇮🇱Israel jsacksick
Also let's not introduce the new methods in Product and ProductVariation and focus on the initial issue solved.
I'm still not convinced by the approach as ideally we should also rewrite the logic that fixes the backreference to the product from the variation.This logic isn't problematic when you're referencing a small number of variations but starting from 50 variations (which isn't that high, saving a product would become awfully slow)... And crash if the number is higher.
- 🇮🇱Israel jsacksick
I am getting error: Undefined method: getVariationTypeId()
This is because the PR is against Commerce 2, the method was removed in Commerce 3, the patch needs to be rerolled.
- 🇪🇬Egypt omnia.ibrahim
I am getting error:
Undefined method: getVariationTypeId()