- Issue created by @chamilsanjeewa
- 🇺🇸United States itmaybejj
It won't address the single icon -- that is by design -- but I'll be tagging a release shortly that fixes the invalid aria description.
-
itmaybejj →
committed 2eca1118 on 1.0.x
[#3545745] bug: Aria-describedby not deduplicating with icon.
-
itmaybejj →
committed 2eca1118 on 1.0.x
- 🇺🇸United States itmaybejj
There -- tagged a release → for the module with that new library code. That should fix the PopeTech validation errors.
For the moment I am leaving the icon deduplication. This deduplication only happens when there is a combination of a specific action warning ("this link opens an app or a file download") and a general warning ("this link is external or opens in a new window.") The more specific icon "wins" visually on the logic that it is enough of a warning of a differing link purpose for users who can see that the new action popped a new window. The library allows adjusting priority to control which icon wins.
If someone wanted to add an option to not deduplicate icons, they would need to go to the location in the JS where the text merges for multiple hits, have it check a config option and then generate and insert the relevant icon, and add that new config option to both the library and the module.
I don't plan to take that on because I think the current solution is a good balance of informative and annoying, but I would be happy to offer tips and testing if someone wanted to try.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.