- Issue created by @jonathan1055
- Merge request !33#3545230 Remove deprecations in 3rd-party modules → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
First commit demonstrates the problem. Only group gtd1 in 'next minor' fails, because this is the test which enables the module. No failure at 'current' because that uses the default setting.
- 🇬🇧United Kingdom jonathan1055
After the addition of the projects own .deprecation-ignore.txt the job shows a reduction down to 15 deprecations
- 🇬🇧United Kingdom jonathan1055
- 🇬🇧United Kingdom jonathan1055
The full pipeline is green, so I am going to merge this.
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...I will investigate if we need to cherry-pick to d9-basic. I don't think we do, but would be good to have the module enabled in the tests anyway, to keeo as much aligned as possible.
-
jonathan1055 →
committed 5bb80458 on d10-plus
[#3545230] fix: Deprecations in 3rd-party modules By: jonathan1055
-
jonathan1055 →
committed 5bb80458 on d10-plus
-
jonathan1055 →
committed e44ffe46 on d9-basic
[#3545230] feat: Align with d10-plus By: jonathan1055
-
jonathan1055 →
committed e44ffe46 on d9-basic
- 🇬🇧United Kingdom jonathan1055
d9-basic does not need the
.deprecations-ignore.txt
file because that branch is designed to be tested at Drupal 9 and 10 only. However, there were some other minor changes that I have replicated from d10-plus, to keep things aligned where appropriate. Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- 🇪🇸Spain fjgarlin
Sorry, I missed the "Needs review" here (really busy last 10 days...). Thanks for the work here!
- 🇬🇧United Kingdom jonathan1055
No problem. Actually I was not expecting you to review it, so I'm not sure why I set to NR. I knew you have a lot else on right now.