- Issue created by @penyaskito
- Merge request !30Issue #3544865: Ensure access to content templates give access to canvas UI. → (Merged) created by penyaskito
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
We have lots of coverage for canvas field related access as kernel tests, so this only covers early returns with a unit test.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- Can you provide screenshots that confirm the (very helpful! 🙏) comments you added in
src/Access/CanvasUiAccessCheck.php? - Also: why not expand
\Drupal\Tests\canvas\Kernel\Controller\CanvasControllerTest::testControllerExposedPermissions()instead of add a unit test for a subset?
- Can you provide screenshots that confirm the (very helpful! 🙏) comments you added in
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Can you provide screenshots that confirm the (very helpful! 🙏) comments you added in
src/Access/CanvasUiAccessCheck.php?This isn't true at the moment. The UI requires access to edit pages.
If you only have access to e.g. content templates, you cannot see the menu bar, you see an error on the page navigator, and you see the auto-saved pending changes list.Also: why not expand \Drupal\Tests\canvas\Kernel\Controller\CanvasControllerTest::testControllerExposedPermissions() instead of add a unit test for a subset?
That has coverage, IMHO one thing is the exposed permissions flags and another the UI access check itself.
-
wim leers →
committed bc81ce0a on 1.x authored by
penyaskito →
[#3544865] feat: `CanvasUiAccessCheck` should grant access if the user...
-
wim leers →
committed bc81ce0a on 1.x authored by
penyaskito →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.