Module hooks have successfully been converted to OOP.
It would be great to convert Theme hooks to OOP.
This requires several changes and architectural changes.
Architectural decision 1
Theme hooks are different than module hooks in the following ways
1. Order is fixed
2. Only certain alters are available
We have two approaches to handling this:
First we can use Hook and throw an error if the module parameter or order parameter are set.
Second we can create a new Attribute that only has the necessary parameters
I strongly prefer the first option since it keeps the hook system closer, if we come up with a really good name for the new attribute that might be cleaner to delineate the differences.
Architectural decision 2
Currently ThemeManager is the one that handles hook execution even though we have a ThemeHandler
Do we want to move hooks execution to ThemeHandler
N/A
There are several test failures that look like a gap in KernelTestBase
Figure out test failures
Figure out how to split this across issues
N/A
TBD
oh boy
TBD
TBD
Active
11.0 🔥
extension system
Failures without the kernel test base changes:
Kernel Tests