- Issue created by @tedbow
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Refactor ApiLayoutController into 2 sub-class to support Content Templates Active is in :)
I think the only person who can efficiently work on this, is @tedbow, so assigning to him.
- πΊπΈUnited States tedbow Ithaca, NY, USA
I have made some progress,
tests/src/Kernel/ApiLayoutController[Get|Post|Patch]Test.php now have test coverage for content templates too.
In process I found and fixed some bugs that we have hit because our current limited test coverage.
Right now a couple test I have edited are failing, haven't investigated why yet.
Because the Content Template UI work will probably run into the bugs either when manually testing or writing tests I think the next steps here should be
- Fix the current test fails
- Clean up the current changes
- Merged the current MR
- Open another MR to continue on updating other tests.
- πΊπΈUnited States tedbow Ithaca, NY, USA
I think all the tests should pass now, re #7, I think we should merge this ASAP and then continue working on the rest of the tests
- πΊπΈUnited States tedbow Ithaca, NY, USA
Created follow-up π Add test setComponentTreeValue to ComponentTreeEntityInterface Active and added todo
- πΊπΈUnited States tedbow Ithaca, NY, USA
Re #7 I think all the tests that need to be converted have actually been converted now. So unless we find something else I don't think we will need to make another MR on this issue
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
#8:
I think all the tests should pass now, re #7, I think we should merge this ASAP and then continue working on the rest of the tests
+1 for this pragmatic proposal. π
Reviewingβ¦
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This MR is very painful to review thoroughly. Without @tedbow's comments, it'd have taken me even longer. π
P.S.: also reviewed π Add test setComponentTreeValue to ComponentTreeEntityInterface Active .
- πΊπΈUnited States tedbow Ithaca, NY, USA
Chatted with @wim leers.
To avoid making issue take longer I reverted
https://git.drupalcode.org/project/canvas/-/merge_requests/31/diffs?comm... and https://git.drupalcode.org/project/canvas/-/merge_requests/31/diffs?comm...Wim had tried to make sure we were using ContribStrictConfigSchemaTestTrait but that needed changes to \Drupal\Tests\canvas\TestSite\CanvasTestSetup which then caused e2e test failures
We already have π Decouple kernel tests from XbTestSetup Active . I commented on that issue to try and use ContribStrictConfigSchemaTestTrait
-
tedbow β
committed 473d754c on 1.x
[#3543834] feat: Refactor all or most `ApiLayoutController*Test` classes...
-
tedbow β
committed 473d754c on 1.x
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.