Replace Experience Builder name everywhere

Created on 27 August 2025, 1 day ago

Overview

Starting a script

Proposed resolution

User interface changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Miscellaneous

Created by

πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tedbow
  • Pipeline finished with Failed
    1 day ago
    Total: 402s
    #583430
  • Merge request !1485Draft: Resolve #3543402 "Script only" β†’ (Open) created by tedbow
  • Pipeline finished with Failed
    1 day ago
    Total: 328s
    #583434
  • Pipeline finished with Failed
    1 day ago
    Total: 603s
    #583444
  • Pipeline finished with Failed
    1 day ago
    Total: 890s
    #583440
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    I

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    I ran tests/src/Kernel/ApiLayoutControllerGetTest.php locally and only 1 test failed.

    The failure was because the client "type" for components has some sort of hash at the end. So it changed from

    'type' => 'sdc.cv_test_sdc.two_column@d99140cbd47c0b51',
    to
    'type' => 'sdc.cv_test_sdc.image@cc9b97c9370aabdf',
    so only the hash after `@` I always ignored this. But is this because it is somehow related the file, module, or path that has changed?

    We could update all of these but also is it really more that these match exactly? Could we write `assertSameXB()` that would compare arrays and let "type" match more loosely? If so we could do this in another issue as prep

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Not currently working on this

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    Working on this for a bit.

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    Proposal for a workflow to collaborate on this working with the two branches.

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    Ok, I'm stepping back before I get on Ted's toes.
    I wrote a proposal for collaborating on this on the IS. That should make possible to collaborate with less risk. Please review.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    @penyaskito another option for how to work would just be to remove of `scripts/src/ConverterCommand.php` from the 3543402-replace-experience-builder branch. The we change the script to have argument TARGET_DIRECTORY

    Then to run the script you just have 2 clones of the repo locally
    3543402-script-only - doesn't need to be a in drupal core directory, only used to run the script
    3543402-replace-experience-builder is the actually version that will be changed

    so from inside 3543402-script-only you would run composer rename -=TARGET_DIRECTORY=/path/to/other/clone

    Or would it simpler to just have 1 MR? since the script doesn't change itself at all it could work.
    I just made 2 MR's because the 3543402-replace-experience-builder hads thousands of file changes so I thought would be harder to look at just the script.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    So to be clear I didn't really have a reason to make 2 MRs versus just 1 expect when I saw the number of files changed I thought it would hard to find the script file and the changes need just for it, like composer.json scripts changes. Also wonder if gitlab UI would be laggy with so many changes.

    So whatever works for people

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    I'm aware Ted is not working on this ATM and I'm not planning to do so for a few hours.

  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    AMAZING WORK both of you! 🀯🀩

    933+ files, +10082, βˆ’11279 πŸ•Ί

    @tedbow in #5:

    • Amazing that there's only such a trivial failure!
    • Yes, those hashes are important. It's essential for data integrity. Observing the hashes change throughout the codebase is an important indicator of things either working correctly or being broken (depending on which code change triggers those versions changing).

    Looking forward to continuing where y'all left off in ~1.5-2 hours. (@jessebaker and I will start pairing on it at his start of day.)

  • Pipeline finished with Failed
    about 19 hours ago
    #583962
  • Pipeline finished with Failed
    about 19 hours ago
    #583917
  • Pipeline finished with Running
    about 18 hours ago
    #584050
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    Update with the gitlabci.yml restoring.

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί
  • Pipeline finished with Failed
    about 15 hours ago
    #584212
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί
  • Pipeline finished with Failed
    about 14 hours ago
    #584245
  • Pipeline finished with Running
    about 14 hours ago
    #584292
  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA

    Been working on this for a while...
    Just phpunit tests we have failures...

    1. CollapseComponentInputsUpdate & CollapseComponentInputsUpdateTest- fails because update .gz fixture probably needs to remade, I guess in the converted version.
    2. ComponentValidationTest.php - fails at least because of component version strings
    3. SegmentFormTest.php - Form field with id|name|label|value "settings[theme]" not found. // not sure why
    4. SingleDirectoryComponentTest.php & CanvasTwigExtensionFiltersTest.php & ParametrizedImageStyleTest.php- probably itok replacements
    5. PropShapeToFieldInstanceTest.php mega array that needs reordering

    Probably a few more but I tired of looking through the logs right now. I am probably done for the day

  • πŸ‡ͺπŸ‡ΈSpain penyaskito Seville πŸ’ƒ, Spain πŸ‡ͺπŸ‡Έ, UTC+2 πŸ‡ͺπŸ‡Ί

    Working on this.

Production build 0.71.5 2024