- Issue created by @seanr
- @seanr opened merge request.
- πΊπΈUnited States seanr
These errors don't read like anything of mine (I barely touched anything π€£) - gonna need some input on this, but I wonder if these were failing already?
1) Drupal\Tests\mailchimp_lists\Functional\MailchimpListsTest::testGetList Attempt to read property "id" on bool /builds/issue/mailchimp-3542646/modules/mailchimp_lists/tests/src/Functional/MailchimpListsTest.php:27 /builds/issue/mailchimp-3542646/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 2) Drupal\Tests\mailchimp_signup\Functional\MailchimpSignupFormTest::testSignUpForm Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "mc_lists[57afe96172]" not found. /builds/issue/mailchimp-3542646/vendor/behat/mink/src/WebAssert.php:731 /builds/issue/mailchimp-3542646/web/core/tests/Drupal/Tests/UiHelperTrait.php:90 /builds/issue/mailchimp-3542646/modules/mailchimp_signup/tests/src/Functional/MailchimpSignupFormTest.php:65 /builds/issue/mailchimp-3542646/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 3) Drupal\Tests\mailchimp_signup\Functional\MailchimpSignupFormTest::testEditSignUpForm Behat\Mink\Exception\ResponseTextException: The text "Signup Forms" was not found anywhere in the text of the current page. /builds/issue/mailchimp-3542646/vendor/behat/mink/src/WebAssert.php:907 /builds/issue/mailchimp-3542646/vendor/behat/mink/src/WebAssert.php:293 /builds/issue/mailchimp-3542646/web/core/tests/Drupal/Tests/WebAssert.php:979 /builds/issue/mailchimp-3542646/modules/mailchimp_signup/tests/src/Functional/MailchimpSignupFormTest.php:135 /builds/issue/mailchimp-3542646/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 4) Drupal\Tests\mailchimp_signup\Functional\MailchimpSignupFormTest::testSubscribeWithMinimalConfiguredSignUpForm Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Sign up" not found. /builds/issue/mailchimp-3542646/web/core/tests/Drupal/Tests/WebAssert.php:158 /builds/issue/mailchimp-3542646/web/core/tests/Drupal/Tests/UiHelperTrait.php:83 /builds/issue/mailchimp-3542646/modules/mailchimp_signup/tests/src/Functional/MailchimpSignupFormTest.php:178 /builds/issue/mailchimp-3542646/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
- πΊπΈUnited States xenophyle
Ah, good catch. Will your fix work without the
use function GuzzleHttp\default_user_agent;
line?
The failing tests are not likely to be your fault -- they need a lot of work.