Child credit validation not checking for active status

The validation that prevents child credit amount from being greater than the parent credit amount does not check whether the credit is active.

This can be a problem if a credit type and its child have default max amount values where the child amount is greater than the parent. Even if the credit isn’t enabled on the course, the validation will be triggered. It could also be a problem if the credit type had been active but then an admin decided to de-activate it without blanking out the max amount fields.

STR:

1. Go to node/add/course
2. Set a child credit type max value to be greater than its parent
3. Do NOT activate the credit types
4. Attempt to save the course and a validation error will occur “Child credit maximum cannot be higher than parent credit maximum”