- Issue created by @phenaproxima
- Merge request !48Issue #3541905: Undefined array key `menu_depth` breaks PHPUnit tests β (Merged) created by phenaproxima
- π¨π¦Canada mparker17 UTC-4
For the purposes of documentation, the
menu_depth
option was introduced in β¨ Add an option for menu depth Needs review , which includedsitemap_update_8205()
to update configuration.Instructions for running
sitemap_update_8205()
were mentioned in the Upgrade instructions section of the 8.x-2.1 release notes β (I took time writing that section, because there's been some confusion after previous releases about how to upgrade the module β see π Route "sitemap.page" does not exist error after upgrading to 8.x-2.0-beta7 Fixed )As a module maintainer, I'm curious to know what I could do to avoid this in the future. That is to say, what is Drupal CMS testing that I'm not testing? How could I improve test coverage to avoid this?
- π¨π¦Canada mparker17 UTC-4
Reviewing the code, it looks good to me.
-
mparker17 β
committed 5b1d5eb9 on 8.x-2.x authored by
phenaproxima β
[#3541905] fix: Undefined array key `menu_depth` breaks PHPUnit tests...
-
mparker17 β
committed 5b1d5eb9 on 8.x-2.x authored by
phenaproxima β
- π¨π¦Canada mparker17 UTC-4
@phenaproxima, it has been merged!
Can I assume you'd like me to make a bugfix release right away?
- π¨π¦Canada mparker17 UTC-4
Updating status and issue summary so it's easy to figure out what happened in the future.
- πΊπΈUnited States phenaproxima Massachusetts
@mparker17, thanks for merging this! An immediate bugfix release is not necessary unless you really want to; this is currently only affecting Drupal CMS's tests, and therefore we have no problem patching it for development.
- π¨π¦Canada mparker17 UTC-4
I released sitemap-8.x-2.2 β today with this fix. Thanks @phenaproxima!
Please do let me know if there's anything that I can do to improve my test coverage so I don't break Drupal CMS tests in the future!
Automatically closed - issue fixed for 2 weeks with no activity.