📌 Simplify getAssociatedRevisions() and getAssociatedInitialRevisions() from core Active added a custom implementation for WseWorkspaceAssociation::getAssociatedRevisions() and ::getAssociatedInitialRevisions() which is supposedly improved based on how this module is architected. Fair enough.
But \Drupal\workspaces\WorkspaceManager::purgeDeletedWorkspacesBatch() expects to only receive one revision ID per entity ID and now it receives multiple. This causes the following loop to attempt to delete an entity with its revisions multiple times, leading to "TypeError: get_class(): Argument #1 ($object) must be of type object, null given"
foreach (array_keys($associated_revisions) as $revision_id) {
if ($count > $batch_size) {
continue 2;
}
// If the workspace is tracking the entity's default revision (i.e. the
// entity was created inside that workspace), we need to delete the
// whole entity after all of its pending revisions are gone.
if (isset($initial_revision_ids[$revision_id])) {
$associated_entity_storage->delete([$associated_entity_storage->load($initial_revision_ids[$revision_id])]);
}
else {
// Delete the associated entity revision.
$associated_entity_storage->deleteRevision($revision_id);
}
$count++;
}
With the original implementation, this would never have happened as that implementation properly joins the base table with the revision table, leading to only one revision ID per entity ID.
Fix
N/A
N/A
N/A
Active
2.0
Code
Attached MR doesn't fix anything, it merely reverts to calling the parent so we have a patch to use while otherwise using the latest version of WSE. Waiting for maintainer response to decide a proper fix before doing any real work.