Profile Label Subscriber should not return NULL

Created on 17 August 2025, 7 days ago

Describe your bug or feature request.

Profile::getLabel() normally returns a label that is entity type + entity id. e.g. "Customer information #1".

The Profile Label Subscriber responds to the PROFILE_LABEL event to provide a more meaningful label, the first line of the address, e.g. "123 Main Street".

If, for some reason, the addressline1 is NULL, though, we overwrite the "Customer information #1" with NULL.

This causes a WSOD when $entity->toLink() is called on the entity and the link is rendered. This occurs on the profile list builder, for example.

While having an address without an addressline1 is an edge case, it can happen, for example if a payment gateway is providing the address, but either fails to provide the address line 1, or returns it in an unexpected property.

Better for us to fall back to the generic "Customer information #1", than cause a WSOD.

If a bug, provide steps to reproduce it from a clean install.

Update a profile address to have a NULL addressline1.

View the profile in the profile list builder. (Or, call $profile->toLink()->toString().)

🐛 Bug report

Status

Active

Version

3.0

Component

Order

Created by

🇺🇸United States TomTech

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @TomTech
@tomtech opened merge request.
Comment 7 days ago →
🇺🇸United States TomTech
This MR adds a check that skips the Event::setLabel() if addressline1 is not populated.
First commit to issue fork.
Comment 6 days ago →
System Message

jsacksick → committed 1a6361f0 on 3.x authored by tomtech →
Issue #3541746 by tomtech, jsacksick: Profile Label Subscriber should...
Comment 6 days ago →
🇮🇱Israel jsacksick
I slightly modified the code to return only in case the profile has no addressfield or an empty address line 1 (to get rid of the big nested if).
Thanks for this.
Comment 6 days ago →
🇮🇱Israel jsacksick
Committed a buggy change that I fixed just now... (See https://git.drupalcode.org/project/commerce/-/commit/ca0f584a78901563a96...).

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024