Spammaster settings cannot be overridden via settings.php

Created on 14 August 2025, about 11 hours ago

Problem/Motivation

In all places throughout the module where the 'spammaster.settings' need to be used, they are loaded as editable config, for example:

$spammaster_settings = $this->configFactory->getEditable('spammaster.settings');

In most places, subsequent code is only calling the get method for individual values and never setting or saving the configuration. As a result, if you want to override either the license key or subtype settings for a specific environment, you can't, because editable configuration does not respect those overrides.

I consider this a bug because it's not really a best practice for Drupal modules given there are many use-cases for overriding configuration in the settings.php file. The only time it should be loaded as editable is for the configuration form (which is automatically loaded as editable) or in any part of the code that needs to programmatically modify the settings and save them. For this module that makes perfect sense in the install hook where it uses the API to generate a license, or in the updater service where it sets the license key and saves it again.

In all other places that use the config settings in a read-only fashion, it should call $this->configFactory->get('spammaster.settings'); to fetch immutable config that respects any overrides in the settings.php file.

Proposed resolution

Modify all the calls to getEditable on the config factory for spammaster.settings and spammaster.settings_protection to us "get" instead, where it is not setting any values and saving the configuration.

🐛 Bug report

Status

Active

Version

2.64

Component

Code

Created by

🇨🇦Canada teknocat

Live updates comments and jobs are added and updated live.

Merge Requests

!5Spammaster settings cannot be overridden via settings.php
Merged
🇨🇦Canada teknocat
updated 30 minutes ago

Comments & Activities

Issue created by @teknocat
Comment about 11 hours ago →
🇨🇦Canada teknocat
Merge request !5Update all places where config is need for read-only use to load as immutable instead of editable → (Merged) created by teknocat
First commit to issue fork.
Comment 30 minutes ago →
System Message

pedro-alves → committed d9f550cf on 8.x-2.x authored by teknocat →
Issue #3541464 by teknocat: Spammaster settings cannot be overridden via...
Comment 30 minutes ago →
🇵🇹Portugal pedro-alves
Hi @teknokat

Thanks for the commit. Yes, absolutely right.
There's an issue with the cleanup service not related to your commit. Currently trying to store these as state when in fact they are editable

// Store editable values. $this->configFactory->getEditable('spammaster.settings_protection') ->set('spammaster.spam_master_is_cloudflare', '0') ->set('spammaster.signature', '1') ->save();
Not a major issue, we will fix this soon.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Spammaster settings cannot be overridden via settings.php

Problem/Motivation

Proposed resolution

Merge Requests

!5Spammaster settings cannot be overridden via settings.phpMerged

Comments & Activities

!5Spammaster settings cannot be overridden via settings.php
Merged