- Issue created by @codebymikey
- Merge request !394Issue #3541397 by codebymikey: Load assets using a relative path → (Merged) created by codebymikey
As per the discussion in ✨ Allow users to specify custom files that Test-only changes Active , I've created an issue/MR for loading the relative markdown assets.
- 🇬🇧United Kingdom jonathan1055
This looks good. Obviously we cannot see the results here, as the pages job has not been run. We could make a temporary change to this projects .gitlab-ci.yml page rules so that the job is run in this MR, for verification before merging.
- 🇪🇸Spain fjgarlin
Not a blocker, but how will this impact local testing? https://project.pages.drupalcode.org/gitlab_templates/help/documentation...
We could make a temporary change to this projects .gitlab-ci.yml page rules so that the job is run in this MR, for verification before merging.
That's a good idea, and I've made the changes so it's a manual pipeline for issue forks. I think it's probably worth keeping for testing future changes to the docs.
Sample doc page with relative images running on the issue fork is available here.
Not a blocker, but how will this impact local testing?
That was actually my initial test of the new variable, and it worked well running under localhost.
- 🇬🇧United Kingdom jonathan1055
I agree, it is a good enhancement to add the pages job as manual in MR. Non-maintainers will write to the unique issue fork url (in this case https://gitlab-templates-3541397-c6bfc7.pages.drupalcode.org/) but I think if a maintainer runs the job the output will be to the "real" url https://project.pages.drupalcode.org/gitlab_templates/ - we did some investigation on this in 📌 Allow testing documentation pages via MRs Active
- 🇪🇸Spain fjgarlin
I left some comments on the MR. Given that we are investigating per-issue pages environment in another issue, I'd not add here the option for the manual job,as there is a risk of overwriting the live documentation.
- 🇬🇧United Kingdom jonathan1055
As per the MR comments I have reverted the change to the job
rules:and will add that on 📌 Allow testing documentation pages via MRs Active instead.The "check code" job fails with
Loading composer repositories with package information In CurlDownloader.php line 394: curl error 28 while downloading https://repo.packagist.org/packages.json: Failed to connect to repo.packagist.org port 443 after 10005 ms: Timeout was reachedI re-ran the job and failed in the same way, but I think this is an unrelated error, nothing to do with the changes in the MR.
The doc pages were rebuilt in the earlier job and can be checked here, so this is ready for review.
- 🇪🇸Spain fjgarlin
Yeah, the error was unrelated and it seems fine today. I check the code and it looks good. RTBC.
-
fjgarlin →
committed 0ce2423d on main authored by
codebymikey →
Issue #3541397 by codebymikey, jonathan1055, fjgarlin: Load assets using...
-
fjgarlin →
committed 0ce2423d on main authored by
codebymikey →
- 🇪🇸Spain fjgarlin
This is now merged. See https://project.pages.drupalcode.org/gitlab_templates/info/setup/
Thanks!