- Issue created by @r.van.doorn
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
When using cweagans/composer-patches it is possible to ignore patches from dependencies: https://github.com/cweagans/composer-patches/tree/1.x?tab=readme-ov-file
I'm not sure why the patch was actually added. If you will always need this patch when using this module, this might be a way to get as many people as possible on this patch, although it does introduce some headaches, as we can see here. Maybe it is better to point people to the issue in the installation instructions, instead of hoping the project has composer-patches installed (of course there is a fair chance, but not a 100% guarantee).
Maybe for a really fancy solution, I'm not sure if there is a way to somehow "test" if the issue is resolved through code. If so, this could be done in a hook_requirement, so it is possible to point people to a bit of documentation about this.
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
I did some spelunking in Git, but the patch - in some form or another - has been in the module since the first version of the code. I'd be interested to know what happens when the patch is not applied at all. Will it always break, or only sometimes? Still, I think a better solution is to solve this through documentation on the project page and in the readme (and optionally the mentioned hook_requirements, if it is possible to somehow find out of the patch has been applied or not). Depending on the outcome of the test whether the patch is essential or just recommended, the addition to the documentation could be more or less prominent.