- Issue created by @penyaskito
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
How does this relate to 📌 Provide a locked Default segment Active ? Will that have a special reserved weight that no other
Segment
can set? - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
I'm guessing we will be giving that one a high value, or ensuring all locked segments come last?
- First commit to issue fork.
- 🇬🇧United Kingdom thoward216
I've created an MR for adding weight to Segments, I haven't addressed anything in the Drupal UI for weighting as I saw this issue: 📌 Revisit segments UI: do we need a Drupal UI? Active and I assume it may get addressed there?
I've also not addressed discussion in #2/#3 as seems thats not currently confirmed. But we might need 📌 Provide a locked Default segment Active to land first? Or it get handled in that ticket after this lands?
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
I think that's all we need. We can discuss how do we want to handle #2 in 📌 Provide a locked Default segment Active .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Looks good!
Two bugs:
weight
is not exposed by the HTTP API, which AFAICT will make the UI impossible to implement: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...weight
should either be updated via the HTTP API, or it should have a comment pointing to which issue will make it so: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
As Wim pointed out I missed we need to expose the weight to the client-side. Which means openapi.yml needs updates too.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This looks great now, thanks! 😊
Just one last bug in the OpenAPI spec: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
One last bit was missing, fixed that. Awaiting green CI results 🤞
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Actually, as I was about to merge, all the
weight: 0
lines that were deleted in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... should be restored 😅 They were totally right — without those, the examples do would not be valid against their (now updated) schema!Restored all deleted lines in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
Again awaiting green CI results, then merging.
-
wim leers →
committed d2ab0c9b on 1.x authored by
thoward216 →
Issue #3541152 by thoward216, wim leers, penyaskito: Ensure segments...
-
wim leers →
committed d2ab0c9b on 1.x authored by
thoward216 →
Automatically closed - issue fixed for 2 weeks with no activity.