- Issue created by @andreastkdf
-
andreastkdf →
committed 1030f720 on 1.0.x
#3540483: Add new option to cleanup filename of the generated file
-
andreastkdf →
committed 1030f720 on 1.0.x
-
andreastkdf →
committed 68bc9b7c on 1.0.x
Revert "#3540483: Add new option to cleanup filename of the generated...
-
andreastkdf →
committed 68bc9b7c on 1.0.x
- Merge request !29#3540483: Add new option to cleanup filename of the generated file → (Open) created by andreastkdf
- 🇬🇧United Kingdom scott_euser
Thanks for working on this! A couple comments though:
- The merge request itself is empty; would suggest using the buttons in the issue summary area to create branch & fork & merge request
- Looking at what's here so far, I think that /admin/config/media/file-system covers most of the options around filenames (lowercase/remove space/transliterate).
- The removal of stop-words is an opinionated bit that is perhaps either better kept as a custom token using the "Generated PDF filename pattern".
Test coverage being addressed in 🐛 Fix test coverage Active as its failing in monthly pipeline as well, not related to here (or at least not fully).
So possibly this is 'Closed (works as designed)' but feel free to disagree
- 🇬🇧United Kingdom andreastkdf
Thanks for checking @scotteuser →
Not sure how I managed to mess up the MR/commit before, didn’t realise. Made a mess as I initially committed to the 1.0.x branch directly (and reverted when I realised) – likely something went wrong with my git commands after that and I didn’t realise. Fixed now, and changes are correctly committed and showing on the MR.
Agree on the stop words being opinionated. This came from a client request who can’t handle it with tokens, so I added it here in case it’s useful for others.
Happy to close. If people are interested, they can use the patch and comment if they’d like to see it added as an option in the future (maybe with a configurable stop words list).
- 🇬🇧United Kingdom scott_euser
Could it be a custom hook token that then subsequently evaluates default token setup, and then strips stopwords from the evaluated token?
- 🇬🇧United Kingdom scott_euser
As discussed further offline, just to recap - closing this because custom token is the way to go that is something project specific like this. Thanks!