- Issue created by @nicxvan
- πΊπΈUnited States nicxvan
There was a comment here #3520416-30: [meta] Handle calls to functions that still require .module file autoloading. β
I'm still not quite sure what @berdir meant there unless he means this should just call CallableResolver with no try catch so it dies if it fails.
I'm going to set this as needs review in the meantime.
- π¨πSwitzerland berdir Switzerland
> unless he means this should just call CallableResolver with no try catch so it dies if it fails.
That's exactly what he meant. That's what it should be IMHO. The only question is whether or not we need to worry about BC here. But I don't see a reason why you'd expect to be able to provide a callback here that doesn't actually work.
That said, the reason I pushed for this to be a separate issue is that I think all batch related callbacks should use this. Essentially all call_user_func_array() calls in batch.inc
- πΊπΈUnited States nicxvan
Thanks for confirming!
I started with just pulling out this one try catch.I then did a naive replacement in batch.inc, let's see what tests say.
- πΊπΈUnited States nicxvan
Some tests are failing there were a few related to the number of arguments splat operator took care of most of them but there are still a couple failures I haven't had a chance to review.
I think it's still the number of args calluserfuncarray handle it differently.
- πΊπΈUnited States nicxvan
(Drupal\Tests\system\Functional\Batch\Processing)
β Batch form multiple batches
β Batch form programmatic