Created on 5 August 2025, about 1 month ago

Problem/Motivation

There are a lot of borders and copyediting that I think can be simplified.

Proposed resolution

Will comment on MR.

๐Ÿ“Œ Task
Status

Active

Version

1.0

Component

User interface

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @drumm
  • @drumm opened merge request.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US
  • ๐Ÿ‡ช๐Ÿ‡ธSpain fjgarlin

    I think it all makes sense, and it's cleaner. Thanks! RTBC and merging shortly.

  • ๐Ÿ‡ช๐Ÿ‡ธSpain fjgarlin

    Merged.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    FYI, 'task' is widely used for conventional commits, and it maps to one of our most regularly used issue categories. Instead of calling this field "Task type" Could we call it "Commit type" and leave "task" as one of the possible options?

    Speaking of which, would it be easy for this UI to default this field based on the current value of 'Category' in the issue? Or is that wasted effort as we're migrating to GitLab issues? Happy to spin off a follow-up, if desired, or to drop it.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States drumm NY, US

    https://www.conventionalcommits.org/en/v1.0.0/ doesnโ€™t mention task, and neither do either example extension that the spec links to. They do have chore, and quite a few others.

    I see you introduced task early in ๐ŸŒฑ [policy] Decide on format of commit message Active .

    There will be some amount of time for the Drupal community to establish norms for the commit types we use. How should we be thinking about deciding which ones get included?

    Speaking of which, would it be easy for this UI to default this field based on the current value of 'Category' in the issue? Or is that wasted effort as we're migrating to GitLab issues? Happy to spin off a follow-up, if desired, or to drop it.

    In GitLab, we wonโ€™t necessarily have a Category::Bug/Task/Feature/Support/Plan label, see ๐ŸŒฑ Using GitLab labels for issues on Drupal projects Active . Every migrated project will have those from migration, and we might set up new projects with defaults, but we donโ€™t have to require maintainers to keep them. That said, we could potentially have magic label names that map the commonly-used ones.

  • ๐Ÿ‡ช๐Ÿ‡ธSpain fjgarlin

    I changed the wording in the commit above to "Commit type".

    The input is already dynamic and it's extremely easy to change (eg: type "chore"). I think that reading from metadata that might or might not be there, especially where we still don't have a convention, is unnecessary.

    Once issue have moved to GitLab and we start using tags, if there is an agreement from the community, we could read that dynamically, but we are not there yet.

    Marking the issue as Fixed again as the wording change was made (it will be deployed today).

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024