- Issue created by @drumm
- @drumm opened merge request.
- ๐ช๐ธSpain fjgarlin
I think it all makes sense, and it's cleaner. Thanks! RTBC and merging shortly.
-
fjgarlin โ
committed 4af02c22 on 1.0.x authored by
drumm โ
Issue #3539905 by drumm, fjgarlin: Simplify UI
-
fjgarlin โ
committed 4af02c22 on 1.0.x authored by
drumm โ
- ๐บ๐ธUnited States dww
FYI, 'task' is widely used for conventional commits, and it maps to one of our most regularly used issue categories. Instead of calling this field "Task type" Could we call it "Commit type" and leave "task" as one of the possible options?
Speaking of which, would it be easy for this UI to default this field based on the current value of 'Category' in the issue? Or is that wasted effort as we're migrating to GitLab issues? Happy to spin off a follow-up, if desired, or to drop it.
- ๐บ๐ธUnited States drumm NY, US
https://www.conventionalcommits.org/en/v1.0.0/ doesnโt mention
task
, and neither do either example extension that the spec links to. They do havechore
, and quite a few others.I see you introduced
task
early in ๐ฑ [policy] Decide on format of commit message Active .There will be some amount of time for the Drupal community to establish norms for the commit types we use. How should we be thinking about deciding which ones get included?
Speaking of which, would it be easy for this UI to default this field based on the current value of 'Category' in the issue? Or is that wasted effort as we're migrating to GitLab issues? Happy to spin off a follow-up, if desired, or to drop it.
In GitLab, we wonโt necessarily have a
Category::Bug/Task/Feature/Support/Plan
label, see ๐ฑ Using GitLab labels for issues on Drupal projects Active . Every migrated project will have those from migration, and we might set up new projects with defaults, but we donโt have to require maintainers to keep them. That said, we could potentially have magic label names that map the commonly-used ones. -
fjgarlin โ
committed ab1ef6ad on 1.0.x
#3539905: Change wording.
-
fjgarlin โ
committed ab1ef6ad on 1.0.x
- ๐ช๐ธSpain fjgarlin
I changed the wording in the commit above to "Commit type".
The input is already dynamic and it's extremely easy to change (eg: type "chore"). I think that reading from metadata that might or might not be there, especially where we still don't have a convention, is unnecessary.
Once issue have moved to GitLab and we start using tags, if there is an agreement from the community, we could read that dynamically, but we are not there yet.
Marking the issue as Fixed again as the wording change was made (it will be deployed today).
Automatically closed - issue fixed for 2 weeks with no activity.