Add attribute discovery support for our plugin types

Created on 4 August 2025, 13 days ago

Change record: Plugin implementations should use PHP attributes instead of annotations β†’

I already had this implemented in πŸ› Fix failing pipelines Active but then decided to split it into a separate issue so it can be more thoroughly reviewed and tested.

πŸ“Œ Task
Status

Active

Version

1.0

Component

Framework

Created by

πŸ‡¦πŸ‡ΉAustria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @drunken monkey
  • @drunken-monkey opened merge request.
  • πŸ‡¦πŸ‡ΉAustria drunken monkey Vienna, Austria

    Opened an MR with the code from πŸ› Fix failing pipelines Active .

  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    This merge request looks great and I think we can merge this. Since the discovery of normal annotations is not yet disabled, this shouldn't impact any plugins out in the wild.

  • πŸ‡¦πŸ‡ΉAustria drunken monkey Vienna, Austria

    Thanks for the feedback, good to hear!
    I think I’ll still leave it open for a few days more before merging, just to be on the safe side.

    I also now stumbled over #3099471: Deprecate "hidden" definition key in favor of "no_ui" β†’ , which I had forgotten but makes sense – all other of our plugin types now have a $no_ui property, but processors only have $hidden, which we now had to make explicit. (Up to now we had silently accepted both.)
    The good thing about this move is that people will have to manually (or semi-manually) switch from annotations to attributes anyways, so now would probably be a perfect moment to switch to $no_ui, if we want. Or to add both but deprecate $hidden right away.
    Not sure whether the additional consistency is worth the hassle, though. Any opinions on this?

  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    I think it's a good idea to do, but if we can create a rector rule, to automate the refactoring, it doesn't have to happen at the same time.

  • πŸ‡¦πŸ‡ΉAustria drunken monkey Vienna, Austria

    You’re probably right, no need to do both at the same time. Thanks!
    Merged.

Production build 0.71.5 2024