Recipe projects (general projects) not indexing field_core_semver_maximum/minimum min/max

Created on 30 July 2025, about 1 month ago

Problem/Motivation

See the @todo in the Contrib recipes plugin.
✨ Create a Contrib Recipes source plugin Active

// @TODO - Recipes are not indexing field_core_semver_maximum/minimum,
// so we have to skip the version check.
// $query_params = $this->addCoreVersionCheck($query_params);

Steps to reproduce

Pulling contrib recipes from the d.o JSON:API - the field_core_semver_minimum/maximum fields are not included/set. Probably they are not being indexed into Solr for those types of projects.

Proposed resolution

Include them in indexing.

πŸ› Bug report
Status

Active

Version

2.1

Component

Drupal.org changes

Created by

πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @chrisfromredfin
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    Should we just take the value of the project that the recipe is in? I'm not sure that'll guarantee compatibility but we need to agree on what the value will be.

  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    Well that's a very good question. I was assuming a recipe.yml would have a core_version_requirements line like module.info.yml's do... guess they don't! The answer may be (a) that we have to show all recipes and let the user figure it out, or (b) we parse the constraint for "drupal/core" out of the composer.json?

    Is (b) feasible? We would have to look at the composer.json's for all versions and come up with our own semver min and max, and that seems a little sloppy to do, considering right now a lot of those constraints are less restrictive than they are for core_version_requirement... so are just something like ">=10.3" - which would not give us the ceiling that core_version_requirement does, where if you don't specify "|| ^11" then it assumes no compatibility with 11+.

    Is putting core_version_requirement in a recipe.yml file even a possibility? Does it make any sense? I may ping Adam to explain why that may or may not be an awful idea.

Production build 0.71.5 2024