- Issue created by @bnjmnm
- @bnjmnm opened merge request.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Adding reference to π Reordering items in a multi-value field doesn't update auto-save unless the user makes another edit Active which needs this.
This will also likely address the concerns expressed in this comment: π XB UI doesn't save the media/image or fields that involve Drupal javascript. Active (the issue was closed based on the summary & title vs the broader concerns found in that comment)
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
In manual testing, this didn't work for me in Firefox. I repeated the testing in Chromium with the same result - didn't work.
What am I doing wrong? The cypress test seems to validate it works.The code changes look good to me.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
What am I doing wrong? The cypress test seems to validate it works.
If I were to follow the steps you provided to reproduce verbatim, I'd get the same symptoms because those recipes don't invoke the experience builder install hooks that enable the
xb_stark
theme that is needed to render the Forms with React and get the preview-updating functionality listed. If I then enablexb_stark
everything works fine in the Firefox and Chrome browsers I tested it in.Based on the screenshot, it looks like
xb_stark
is enabled, but given that the symptoms reported are exactly what I encountered when following the steps to reproduce, it's hard to not to wonder if a lack of xb_stark has something to do with it.Lets rule out the recipes and see if you run into the same issue if XB is enabled directly.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Just to clarify, I did have xb_stark enabled, because I have a Make task for setting up a minimal site from the recipes (too many commands to remember)
xb-minimal: drush si minimal -y cd app && php core/scripts/drupal recipe modules/experience_builder/tests/fixtures/recipes/base cd app && php core/scripts/drupal recipe modules/experience_builder/tests/fixtures/recipes/test_site drush uli -l 127.0.0.1:8080 drush then xb_stark
But I'll retest
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Confirming I still have the same issue and that xb_stark is enabled
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Ah, the issue was xb_vite was disabled and I hadn't run a build
Working now - this looks good to go to me
-
wim leers β
committed 2dc552ac on 1.x authored by
bnjmnm β
Issue #3537872 by bnjmnm, larowlan: Redux-aware form input components...
-
wim leers β
committed 2dc552ac on 1.x authored by
bnjmnm β
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Merging per @larowlan's MR comments and then #11. (I know zero about this.)
Also: π€― @ @bnjmnm's https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
May this fix many Drupal behaviors! π€ Thanks for your wizardry, @bnjmnm!
Automatically closed - issue fixed for 2 weeks with no activity.