ValidDynamicReferenceConstraintValidator doesn't pass correct entity to selection handler

Open on Drupal.org →

Created on 24 July 2025, 2 months ago

Problem/Motivation

I noticed this issue when working on another issue. When validating if a reference is valid, the selection handler is called. (see https://git.drupalcode.org/project/dynamic_entity_reference/-/blob/4.x/s...).

To this selection handler, the entity making the reference needs to be passed (the $entity argument). This argument is instantiated here https://git.drupalcode.org/project/dynamic_entity_reference/-/blob/4.x/s... .

But... it's overridden a bit further on @ https://git.drupalcode.org/project/dynamic_entity_reference/-/blob/4.x/s... .

This means that not the referencing entity is passed to the selection handler, but the last referenced entity.

🐛 Bug report

Status

Active

Version

4.0

Component

Code

Created by

🇧🇪Belgium rp7

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!35ValidDynamicReferenceConstraintValidator doesn't pass correct entity to selection handler
Closed
🇧🇪Belgium rp7
updated about 2 months ago

Comments & Activities

Issue created by @rp7
Merge request !35Issue #3537772: Pass in the correct entity when instantiating the selection handler upon validating referenced entities → (Closed) created by rp7
Pipeline finished with Failed
2 months ago
Total: 119s
#555726
Comment about 2 months ago →
System Message
jibran → closed merge request !35
Comment about 2 months ago →
🇨🇦Canada jibran Toronto, Canada
Duplicate of 🐛 Allow saving pre-existing references to inaccessible items Active .
Comment 28 days ago →
🇧🇪Belgium rp7
I'm not convinced it's a good approach to mark this as a duplicate. It's something completely different (but yes, this fix is a pre-requisite for 🐛 Allow saving pre-existing references to inaccessible items Active ).

We're now waiting on 🐛 Allow saving pre-existing references to inaccessible items Active , while this (pretty trivial) bug fix can go out a lot sooner.

Any chance of moving this forward?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024