- Issue created by @wim leers
- Merge request !1349Resolve #3537666 "Load global asset libraries on default theme only" β (Merged) created by wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Reported by @mglaman in chat.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This can break the admin theme! π π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I bet this fails because
// Case 3: Route with _xb_use_template_draft should use regular asset // library if there is no auto-saved version. $assert_library_global_library('/xb/api/v0/layout/xb_page/' . $page->id(), TRUE);
does not negotiate the default theme.
- First commit to issue fork.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Simpler than that:
\Drupal\Core\Theme\ThemeManagerInterface::getActiveTheme
returns aActiveTheme
object, not the theme name.- The css selectors need to "contains" and not "startWith" because a) the subdir might be included if installed in subdirectory; b) π Provide cache buster query string on imports Active
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Whoops β pretty evident now that I just threw up an MR without actually testing it! π
#9: RE: subdir β how come this worked fine until now?! π³
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
#10 I haven't seen them fail nor tested it, but I was pretty sure this could be a problem?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Investigating the sole lingering concern: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Reverting those test changes passed just fine after locally I was convinced they were not needed β yay, zero concerns left! π₯³
-
wim leers β
committed e71d8b45 on 1.x
Issue #3537666 by wim leers, penyaskito, mglaman: The `global` `...
-
wim leers β
committed e71d8b45 on 1.x
-
balintbrews β
committed 1db1a37c on 0.x authored by
wim leers β
Issue #3537666 by wim leers, penyaskito, mglaman: The `global` `...
-
balintbrews β
committed 1db1a37c on 0.x authored by
wim leers β