Impossible disable Link label to the referenced entity

Some more information would be helpful here. I see "Link label to the referenced entity" as an option only for the core Label formatter (EntityReferenceLabelFormatter).

Screenhosts, error messages, that kind of thing would be great.

anurag_nagar → changed the visibility of the branch 3537582-impossible-disable-link to hidden.

anurag_nagar → changed the visibility of the branch 3537582-impossible-disable-link to hidden.

anurag_nagar → changed the visibility of the branch 3537582-impossible-disable-link to hidden.

anurag_nagar → changed the visibility of the branch 3537582-impossible-disable-link to active.

shubh02 → changed the visibility of the branch 3537582-impossible-disable-link to hidden.

The commit attached to this issue is working for version 2.0.4.
Tried below steps
Select "File download link" in views field formatter.
Unselect "Link label to the referenced entity"
Save.
Reopen settings - checkbox remain unchecked (Test)

This still needs work. The "link" setting is only used by the Entity Label formatter, which is not in any way extended or leveraged by this module.

How do we move forward? First, the issue summary still needs a lot more information. A very key of information that is not clear is that this is specifically a problem with the file_download_link_media formatter when used one a Views field.

Here's a screenshot like I asked for:

That really helps things because we see that the settings form for the File Download Link formatter isn't displayed. Where are all the configuration options like "Link Text" "Open file in new tab" and the "Example Token" drawer?

That's the bug. That's what we need to fix.

Here's how it looks if I'm using the non-media field_download_link formatter to render an Image field (not media) in Views:

Why does the setting form load for the normal file_download_link formatter but not the file_download_link_media formatter?

@danflanagan8 Yes I agree this issue needs more details , but according to my understanding there is one issue other than what you have mentioned.

1. Use Entity reference field ( for example taxonomy field)
2. Select File Media Formatter as it is available in dropdown
3. Link Label to the referenced entity checkbox settings stops working.
4. Try uncheck/check the Link Label to the referenced entity the changes will not get saved.

@danflanagan8 I have added a commit in which I have fixed the settingsform fields not getting visible for FileDownloadLinkMedia formatter. Please review.

Ok, this is making more sense now. What I'm wondering now is why does File Download Link even appear as an option when it is not applicable?

It's intentional that the file_download_link_media field formatter is only available for media fields that can only reference media with an image or file source. Other media sources simply aren't supported. When configuring a View field, if the site has any media types that use other source plugins, the plugin should not be applicable.

The real bug is that File Download Link shows up at all in this situation. This is really a bug in Views: 🐛 Views should respect the field formatter's isApplicable() method Needs work

I'm going to change this to a support request so I can mark it as fixed and grant credit.

Thanks for digging into this one, @anurag_nagar.

Cheers!

danflanagan8 → closed merge request !14

Automatically closed - issue fixed for 2 weeks with no activity.