- Issue created by @jonathan1055
- Merge request !98#3537090 Add static to two data provider methods → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
The warnings in PHPUnit no longer show
https://git.drupalcode.org/issue/token-3537090/-/jobs/5958549
The phpunit errors are for other exitsing problems. The tests still pass green in Previous Minor (11.1) and Previous Major (10.5)and the PHPStan mesages are also fixed
https://git.drupalcode.org/issue/token-3537090/-/jobs/5958544This is ready for review.
- 🇬🇧United Kingdom jonathan1055
This correction has also removed the warning
No tests found in class "Drupal\Tests\token\Kernel\LanguageTest
which means that tests in this class are now being run (they were not, before). We get the extra lineDrupal\Tests\token\Kernel\LanguageTest 30 passed
I've compared the logs before and after, and all other test results are the same.
So this is not just about fixing the warning, but also it restores test coverage for the LanguageTest. - First commit to issue fork.
-
berdir →
committed 3ea0c877 on 8.x-1.x authored by
jonathan1055 →
Issue #3537090 by jonathan1055: Data provider methods should be static...
-
berdir →
committed 3ea0c877 on 8.x-1.x authored by
jonathan1055 →