- Issue created by @bkosborne
- Merge request !14Load latest revision of a node before modifying it. β (Merged) created by bkosborne
- πͺπΈSpain fjgarlin
Why donβt we offer this as a setting in the new settings form?
That way we can let site maintainers decide whatβs better for their case.
We can offer both options as radio input with a little description about the implications.
- πΊπΈUnited States bkosborne New Jersey, USA
I put some more thought into this given your suggestion. But I've become more convinced that the current behavior is a bug and shouldn't be a choice someone can opt into. I think it's totally unexpected behavior to have a change to a node not update the most recent version of that node, but instead update the published version.
What I'd really prefer to do here is to fix this to load the latest revision, and wait and see if anyone has a need for the existing behavior. This module isn't widely used (yet) so I suspect there aren't any or many people using it with Content Moderation. Basically, I think it's a good idea to keep the module and config options as slim as possible while we can.
- πͺπΈSpain fjgarlin
That's fine with me, your reasoning is sensible. I'm happy to change the behavior to use the latest revision always, and as you say, if somebody were to challenge that, then we can consider other options.
So, I'm happy to use this issue to ensure that we are always updating the last revision of nodes. Not sure if the MR is complete or if it would need extra changes in that case.
- πΊπΈUnited States bkosborne New Jersey, USA
Thanks! This is good to go. I did push another commit that explains why we're doing this too.
- πͺπΈSpain fjgarlin
Small phpcs and cspell changes required. Once that's green it can go directly to RTBC.
- πΊπΈUnited States bkosborne New Jersey, USA
Thanks. I'll commit this and release later this week.
-
bkosborne β
committed 5df1866a on 2.x
Issue #3536852 by bkosborne, fjgarlin: Latest revision of node should be...
-
bkosborne β
committed 5df1866a on 2.x