Fix WishlistItemTest::testAdd()

Created on 17 July 2025, 19 days ago

Problem/Motivation

WishlistItemTest::testAdd() is currently failing due to the missing Add item link. I can reproduce the test failure locally but whenever I go to the wishlist item collection route manually, the link is there... Not sure what is happening yet.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇮🇱Israel jsacksick

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jsacksick
  • 🇮🇱Israel jsacksick

    hm... Actually I managed to reproduce this with D11... The wishlist item add page returns a 404.

  • 🇮🇱Israel jsacksick

    Not sure what was the initial reasoning but I don't think we could support more than one purchasable entity type properly without passing the type from the url...

    Also, since there is no wishlist item type setting for example at the wishlist type level, not sure how we could properly determine the type to use?

    Or maybe we'd need a deriver defining local actions for each purchasable entity type defined, but that would result in a weird experience...

    "Add product variation item"?

  • @jsacksick opened merge request.
    • jsacksick committed c00cdb95 on 8.x-3.x
      Issue #3536634 by jsacksick: Specify a default bundle for the add form...
  • 🇮🇱Israel jsacksick

    hm... Just realized a much simpler alternative was possible... By overridding the "_entity_create_access" route requirement as done for Commerce pricelist as done in 🐛 The add price action is missing on D11 Active .

    But it turns out the Wishlist usecase is quite different as we're checking a custom permission (similar to product variations: "manage {$bundle_name} {$entity_type_id}").

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024