- Issue created by @bkosborne
- @bkosborne opened merge request.
- πΊπΈUnited States bkosborne New Jersey, USA
Ready for review.
Since the autocomplete widget and the multi-value select widget submit form values differently, I had to update our form submit handler to normalize the results, but I think it resulted in more readable code anyway.
- πͺπΈSpain fjgarlin
I agree that the new code is more readable. I guess that was a nice side effect of adding the extra widget.
Thanks for the additional test.
- Multiselect widget: https://project.pages.drupalcode.org/-/bulk_edit_terms/-/jobs/5925242/ar...
- Autocomplete widget: https://project.pages.drupalcode.org/-/bulk_edit_terms/-/jobs/5925242/ar...As the tests are working with the two previous choices, I am marking this RTBC. Thanks!!
PS: what do you think about adding tugboat previews for this module? This can go on a separate issue and it'd be as easy as adding one file to the repo (actually two, because it'll need a composer.json file too). Info β and example. This will give us a live environment where we can test manually as well (in addition to the tests).
-
bkosborne β
committed b8e271ad on 2.x
Issue #3536405: Support multi-value select for term assignment instead...
-
bkosborne β
committed b8e271ad on 2.x
- πΊπΈUnited States bkosborne New Jersey, USA
Thanks!
Yes, adding Tugboat previews would be great. We use tugboat quite at bit at my work. If you create the issue I can work on it.
Automatically closed - issue fixed for 2 weeks with no activity.