- Issue created by @bkosborne
- πͺπΈSpain fjgarlin
Those are all great suggestions. All of them, except for the last one, seem pretty quick and straightforward.
I suggest doing all of them except the last one on this issue, and do the last one on a separate issue, so as not to block the quick and easy changes.
- πͺπΈSpain fjgarlin
Or if you still want to do it via one issue, then do it in two separate MRs. I'm happy either way.
- @bkosborne opened merge request.
- πΊπΈUnited States bkosborne New Jersey, USA
Agreed. I'll split that out into a separate issue. I may not even do it here. May be pretty easy with a form alter for our own use case.
- πΊπΈUnited States bkosborne New Jersey, USA
Ready for review. Sorry, the changes look bigger than they are because I had to refactor how the form is constructed a bit. Now the code first gathers the list of all eligible term reference fields, then in a separate loop builds the form. This allowed me to collect the list of content types used by a field with the same name.
- πΊπΈUnited States bkosborne New Jersey, USA
eh, while I could do the change to select widget in a form alter, it's more complex that I'd like since we need to also load the term tree. Creating follow up to add it to the module...
- πͺπΈSpain fjgarlin
The refactoring makes sense and looks good. Tests are also happy. RTBC.
Feel free to merge this yourself with your new admin powers π
-
bkosborne β
committed 1817db35 on 2.x
Issue #3536376 by bkosborne: Additional minor tweaks to UI language...
-
bkosborne β
committed 1817db35 on 2.x