Fix FunctionalJavascript test

Problem/Motivation

In DeclarationFormTest::testOralDeclarationRecordedByStaff(), move the return statement down to just before @todo Fix when added code for cancellation. It needs to be inside if (TRUE) { to avoid a bunch of warnings for unreachable code.

Fix @todo Use ajax to add evidence. so that the submit form succeeds. The code might start something like

$this->assertSession()->waitForElementVisible('named', ['button', 'Add new Gift Aid evidence'])->press();

Ensure that the following code // There should now be a stored declaration. passes.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes