Buy X Get Y promotion creates orphaned order items with NULL order_id when using Calculated Formatter

Created on 15 July 2025, 17 days ago

Describe your bug or feature request.

When creating a "Buy X Get Y" promotion with a 100% discount and enabling the "Automatically add the offer product to the cart if it isn't in it already" option, a new entry in the commerce_order_item table is created with a NULL order_id whenever the product page is viewed or added to the cart.

This issue occurs when using the Calculated Formatter for prices with the option "Apply promotions to the calculated price" enabled.

These orphaned commerce_order_item entities seem to be generated during price resolution and are not properly cleaned up, leading to unnecessary clutter in the database and potential confusion or performance issues.

If a bug, provide steps to reproduce it from a clean install.

1. Install Drupal with Commerce Kickstart or a fresh Commerce installation.
2. Create a "Buy X Get Y" promotion with:
- Offer type: Buy X Get Y
- Discount: 100% off
- Option enabled: "Automatically add the offer product to the cart if it isn't in it already"
2. Disable all caching and clear caches.
3. Visit the product display page for the qualifying "Buy X" product.
4. Add the product to your cart.

🐛 Bug report

Status

Active

Version

3.1

Component

Promotions

Created by

🇨🇾Cyprus akalyptos

Live updates comments and jobs are added and updated live.

Merge Requests

!477Buy X Get Y promotion creates orphaned order items with NULL order_id when using Calculated Formatter
Open
🇮🇱Israel jsacksick
updated 17 days ago

Comments & Activities

Issue created by @akalyptos
First commit to issue fork.
Comment 17 days ago →
🇮🇱Israel jsacksick
Any chance you could test the patch from the attached MR? This is a completely blind fix.
Merge request !477Issue #3536032 by jsacksick, akalyptos: Buy X Get Y promotion creates orphaned... → (Open) created by jsacksick
Comment 17 days ago →
🇮🇱Israel jsacksick
hm.. Maybe not the right fix...as we have $get_order_items[$order_item->id()] = $order_item; later on... Maybe the whole auto add logic should be bypassed in case an unsaved order is passed?
Comment 17 days ago →
🇮🇱Israel jsacksick
So I believe with my changes, the BuyXGetY auto add feature won't work when the price calculated formatter invokes the processsor, at the same time, I don't think it makes sense for the formatter to trigger the creation of a new order item that is then orphaned and saved into the DB permanently.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Buy X Get Y promotion creates orphaned order items with NULL order_id when using Calculated Formatter

Describe your bug or feature request.

If a bug, provide steps to reproduce it from a clean install.

Merge Requests

!477Buy X Get Y promotion creates orphaned order items with NULL order_id when using Calculated FormatterOpen

Comments & Activities

!477Buy X Get Y promotion creates orphaned order items with NULL order_id when using Calculated Formatter
Open