Combine NodeRevisionsAllTest into NodeRevisionsTest

Open on Drupal.org →

Created on 10 July 2025, 3 months ago

Problem/Motivation

NodeRevisionsAllTest contains many duplicate assertions from NodeRevisionsTest but also does a few extra assertions (afaict the only extra thing it does is check the pager). Let's combine the 2 tests.

Proposed resolution

Move pager assertions from NodeRevisionsAllTest::testRevisions into NodeRevisionsTest::testRevisions
Check any other assertions that need to be moved
Delete NodeRevisionsAllTest

Remaining tasks

User interface changes

None

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

None

📌 Task

Status

Active

Version

11.0 🔥

Component

node system

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @acbramley
First commit to issue fork.
Comment about 1 month ago →
🇨🇷Costa Rica thony1199
@thony1199 opened merge request.
Comment about 1 month ago →
🇨🇷Costa Rica thony1199
I've consolidated the tests.

I think this solution should work properly.

PR: https://git.drupalcode.org/project/drupal/-/merge_requests/13078
Comment about 1 month ago →
🇨🇷Costa Rica thony1199
Comment about 1 month ago →
🇨🇷Costa Rica thony1199
Ok, I will do !!
Comment about 1 month ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Needs review 22 days ago5:01am 9 September 2025
Comment 22 days ago →
🇦🇺Australia acbramley

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024