Dimensions and weight missing from inline entity form after updating to Commerce 3

OK, i traced the culprit to commerce_product_update_10301, which according to docblock :

/**
 * Moves 'variationType' setting to the 'variationTypes'.
 */

Problem was that my "variationType" was set to "default", but "variationTypes" was set to "shippable" (and shippable only).

So, after updating, "variationType" is gone, and variationTypes is "default" and "shippable" - not what i want!
And since it's a simple inline entity form, I guess it just uses the first value, which is not correct.

Not sure how this was resolved previously, but turning "default" off again solved it.

Here's the patch I'm using.
I assume maintainers are not gonna want to roll this in, so I won't bother with an MR.
But it's working for me.

hm, no this change doesn't make sense? I think what we should probably do instead is not touch the variationTypes if it is set... Can you open an MR doing this?
We only migrate the values if variationType is set but variationTypes is empty?

Retitling, working on that.

Went ahead and committed the amended update hook which now sets the variation type IDS only if the "variationTypes" setting is empty.

Thanks, that change makes sense to me and should address my use case.

Not sure how or why variationTypes and variationType contained different values previously, but this should fix it.