- Issue created by @effulgentsia
- 🇺🇸United States mglaman WI, USA
I think I hit this with a "simpler" scenario. I have a button link component within the slot of a another component. The page is then visited within the iframe. The problem does not occur if the button link is on its own and not in a slot.
- 🇺🇸United States mglaman WI, USA
Oh, and this effects anything using dynamic code components – menus for example.
- 🇳🇱Netherlands balintbrews Amsterdam, NL
Unassigning as I'm not working on this right now, in case anyone would pick it up.
- 🇺🇸United States mglaman WI, USA
I've got a MutationObserver working, making MR shortly
- @mglaman opened merge request.
- First commit to issue fork.
- @jessebaker opened merge request.
- 🇺🇸United States effulgentsia
Closed 🐛 The navigation prevention inside the preview doesn't always work for code components Active as a duplicate of this. That one was tagged as a stable blocker, so transferring that tag to here.
- First commit to issue fork.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I approved MR 1371 - it's a solid approach that doesn't require DOM vigilance. It's also more comprehensive as it covers keyboard interaction and submits. However, the issue is NR as this expanded functionality should probably get some e2e representation. You should be able to use the Cypress jQuery functionality to add a link to the preview iframe after it loads which would reproduce the scenario this fixes without having to deal with making a component do it.
jQuery('iframe[title="Page preview"]').contents().find("body").append(YOUR LINK[s] )
- 🇬🇧United Kingdom jessebaker
Test, written in Playwright, has been added now. I took the opportunity to also migrate all but one of the tests in
ui/tests/e2e/preview.cy.js
. The remaining test is a bit more tricky so I've not attempted to migrate that here. I've renamed the file toui/tests/e2e/vh-units.cy.js
because it now specifically tests that one thing. - 🇺🇸United States bnjmnm Ann Arbor, MI
The solution I was already happy with, and the new tests look good 👍,.
-
jessebaker →
committed c0330f10 on 1.x
Issue #3535072 by jessebaker, bnjmnm, mglaman: Drupal.behaviors....
-
jessebaker →
committed c0330f10 on 1.x
Automatically closed - issue fixed for 2 weeks with no activity.