Wrap $item->getUrl()->access() in a catch, like the LinkWidget in core does

Open on Drupal.org →

Created on 8 July 2025, 5 days ago

Problem/motivation

We ran into a problem when a link field was being rendered with ajax, such as a content type having a multi value paragraph field containing a link field. The site also needs a role where the permission "Link to any page" from the core system module is NOT set.

Steps to reproduce

Install Drupal with Linkit 7.x and Paragraphs 1.19
Create a user with a role that doesn't have the permission "Link to any page" set.
Create a new paragraph type Test containing a Link field
In the paragraph form display for test, set the Link field to use the Linkit widget, you can just use the default settings
Create a content type Test with only one field; a paragraph field and allow the field to contain Test paragraphs
Add a Test node
Enter "hello broken world" or another link in the Link field that causes validation to fail
Click "Add Link"

Result

The steps above causes Drupal to crash with a 500 error, returning invalid code back to the AJAX form request. Further editing in the form might also be broken.

Proposed resolution

The issue is caused by getUrl in $item->getUrl()->access() not returning a valid URL and then the access for that object failing to get the access, since getUrl throws an InvalidArgumentException when it reaches the fromInternalUri function.

In the core LinkWidget.php class, they have resolved the issue by wrapping $item->getUrl()->access() in a try, catching the InvalidArgumentException and handling it gracefully.

The code in LinkWidget.php assigns a $display_uri, but I don't think we need to copy that part, as LinkitWidget.php doesn't seem to have the same assigning that LinkWidget.php has.

🐛 Bug report

Status

Active

Version

7.0

Component

Code

Created by

🇳🇴Norway svenryen

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!115Wrap $item->getUrl()->access() in a catch, like the LinkWidget in core does
Merged
🇳🇴Norway svenryen
updated 5 days ago

Comments & Activities

Issue created by @svenryen
Comment 5 days ago →
🇳🇴Norway svenryen
Merge request !115Issue #3534671 by svenryen: Wrap $item->getUrl()->access() in a catch, like... → (Merged) created by svenryen
Pipeline finished with Success
5 days ago
Total: 313s
#541865
Comment 5 days ago →
🇳🇴Norway svenryen
Comment 5 days ago →
🇳🇴Norway svenryen
Comment 5 days ago →
🇳🇴Norway svenryen
Pipeline finished with Skipped
5 days ago
#542185
First commit to issue fork.
Comment 5 days ago →
System Message

mark_fullmer → committed e731fa24 on 7.x authored by svenryen →
Issue #3534671: Wrap $item->getUrl()->access() in a catch, like the...
Comment 5 days ago →
🇺🇸United States mark_fullmer Tucson
This analysis is comprehensive and logical, and the proposed resolution of placing the executing code in a try/catch statement to avoid a fatal error, modeled after the behavior in Drupal core, is safe and uncontroversial. Thanks so much for the report, the analysis, and the code change fix!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024