Created on 4 July 2025, 4 days ago

Problem/Motivation

This is an MR with a whole range of minor tweaks I noticed while reviewing.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom jonathanshaw Stroud, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jonathanshaw
  • Merge request !11Resolve #3534223 "Misc fixes" → (Open) created by jonathanshaw
  • 🇬🇧United Kingdom jonathanshaw Stroud, UK

    Most commits are trivial. The DonorAddForm commit contains a substantial rework of things related to ContextOverviewController, DonorAccountForm and related logic. I like where this ended up, something more generic that works with contexts other than the user.

  • 🇬🇧United Kingdom jonathanshaw Stroud, UK
  • 🇬🇧United Kingdom jonathanshaw Stroud, UK

    Regarding the change from DonorAddForm to DonorAccountForm the basic idea is that when I looked at it I realised that it could be more generic than just the user account scenario. It would work with any type of context entity, once I added the DonorInterface::isCurrentUser() method. A site would need to customise the donor entity class to make it work with non-users, but it could be done in principle. It seemed to me like it was turning into a pretty generic Donor 'add' form.

Production build 0.71.5 2024