- Issue created by @fjgarlin
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
ghost of drupal past โ made their first commit to this issueโs fork.
- Merge request !68temporarily force parser v5 to see what happens โ (Merged) created by Unnamed author
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
This is now for review. I dropped php-parser v4 support from Drupal Pretty Printer , there's no need for that now.
The issues were really minor:
ParserFactory::create
is gone.Expr_ArrayItem
is nowArrayItem
- A few things got deprecated but had 100% equivalent replacements so I did that.
Drupal Pretty Printer (which was api not long ago) had two minor problems too, one of them the same as above:
- In method
p
for theCast
case it didn't pass on the arguments new to v5. The method did receive those so it was just adding these to thepPrefixOp
call. pExpr_ArrayItem
needed to be comeArrayItem
. By moving the logic into a common method it would've been possible to keep v4 support but I am not really interested in that any more.
- ๐ช๐ธSpain fjgarlin
The api.drupal.org is on the latest Drupal 10.5.x stable version and it's on PHP8.1. That's exactly what's tested in the "previous major" variant in the pipelines: https://git.drupalcode.org/issue/api-3534214/-/pipelines/546323
The code looks good.
-
fjgarlin โ
committed 17d0f27e on 2.x authored by
ghost of drupal past โ
Issue #3534214 by ghost of drupal past, fjgarlin: Update php-parser...
-
fjgarlin โ
committed 17d0f27e on 2.x authored by
ghost of drupal past โ
- ๐ช๐ธSpain fjgarlin
Merged! I will test locally this and the other merged issues and then deploy.