Contrib.social

Fix eslint issues reported by Gitlab CI

Open on Drupal.org ā†’
Created on 4 July 2025, 3 months ago

Problem/Motivation

Since introducing Gitlab CI, eslint reports errors. See https://git.drupalcode.org/project/form_state_empty/-/jobs/5777389

Steps to reproduce

Run CI. Or run eslint. Or visit the link above.

Proposed resolution

Fix all the issues.

Remaining tasks

All the things.

User interface changes

None hopefully.

API changes

None hopefully.

Data model changes

None.

šŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

šŸ‡¬šŸ‡§United Kingdom Eli-T Manchester

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Eli-T
  • Merge request !4#3534155: šŸšØ eslint fixes. ā†’ (Open) created by Eli-T
  • Comment 3 months ago ā†’
    šŸ‡¬šŸ‡§United Kingdom Eli-T Manchester
  • Comment 3 months ago ā†’
    šŸ‡¬šŸ‡§United Kingdom Eli-T Manchester

    The automated fix patch generated by eslint has fixed some but not all of the issues.

    The remaining issues are:

    /builds/project/form_state_empty/web/modules/custom/form_state_empty/js/state-empty.js
  10:29  error  Expected '===' and instead saw '=='    eqeqeq
  14:13  error  Prefer HTMLInputElement#value to .val  no-jquery/no-val
āœ– 2 problems (2 errors, 0 warnings)
  • Comment 3 months ago ā†’
    šŸ‡¬šŸ‡§United Kingdom Eli-T Manchester

    Eslint is now happy in Github CI.

    A second pair of eyes on the JS changes would be appreciated!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024