Doublecheck settings being merged

I dug into this one a bit and I don't think that line is actually necessary.

It was added early on in 📌 Support additional extensions Active , but was never removed as the MR evolved.

I also removed a default setting for the "tips" form element, which is just static text.

Additionally, I searched in core and a bunch of contrib modules for a something similar and found nothing. There is a setConfiguration() method in web/core/modules/filter/src/Plugin/FilterBase.php, but I don't think it is relevant here.

Tests are passing without this code, and I can't think of any reason why it might be necessary.

Thoughts?

-mike

I have reviewed, and I agree that merging with the default settings isn't doing anything useful.

I also agree returning an empty string for tips in defaultSettings isn't necessary.

Moving to RTBC.

I've removed "tips" from the schema and default Markdown text format. I don't think it's needed, and it is never updated by the settings form, so it will only ever be an empty string.

I've also removed the "Convert line breaks" filter from some tests where it's not relevant.

Also removed a check that the "Convert line breaks" error is not displayed. The error message is no longer in the module, so will never be displayed.

Moving back to needs review.

@lostcarpark - thanks so much, the changes look good and all tests are passing. Merging!

thanks,
-mike