- Issue created by @nicxvan
- 🇮🇹Italy mondrake 🇮🇹
Wonder if we can extend from the same class in the
mysql
module, with some adjustments. Most of themysqli
module is done with a similar pattern.I left the
.install
file on purpose because I understood an hook was coming, and it is a near copy of the now defunct same file in mysql. - 🇺🇸United States nicxvan
I think it's cleaner to do it this way, they are both runtime so you could just invoke the mysql runtime and then tweak it.
Do you mind doing that work in a follow up because this is one of two hook_requirements in core and I'm working on deprecating that hook.
- 🇨🇭Switzerland berdir Switzerland
Verified that the only changed lines are t() to $this->t() within the implementation.
- 🇬🇧United Kingdom catch
Wondered about the extent of copypasta from mysql, good plan to address that in a follow-up, although wonder if that should go in a non @final/final trait that both hook implementations can use or something.
Committed/pushed to 11.x, thanks!
- 🇮🇹Italy mondrake 🇮🇹