Contrib.social

Respect 'name_as_title' Workflow setting

Open on Drupal.org →
Created on 25 June 2025, 3 months ago

Problem/Motivation

The Workflow settings page has a checkbox

"Use the workflow name as the title of the workflow form"

.
The help text is:

"The workflow section of the editing form is in its own fieldset. Checking the box will add the workflow name as a title to the fieldset."

The setting is not respected.
The help txt does not says what the effect is if it is NOT set.
This setting date back from D7, before the current maintainer stepped in, so needed to re-interprete the info.

Steps to reproduce

  • Go to page /admin/config/workflow/workflow/MY_TYPE
  • Toggle the value
  • Check its effect on the Node edit page, Node view page (both with widget WorkflowTransitionForm)
  • Check its effect on the Node's Workflow History page
  • Check its effect on the Node's Workflow Block

Proposed resolution

Since in D7, the Workflow was not a 'real' field, it was needed back then.
To not remove some use cases in the installed base, let us keep the setting.

  • in Workflow.php, set default value to YES
  • in WorkflowTypeForm.php, rephrase the help text a bit.
  • in WorkflowTransitionForm, set the Field label if YES, else leave blank, resulting in default value 'details'. (This only has effect on Node Edit Form / Widget, not on Block or History page)
  • in WorkflowTransitionElement.php, remove the setting, since it overwrite the History page title.
  • in WorkflowTransitionElement.php, the 'to_sid' subwidget, alway use "Change $field_label".

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.1

Component

User interface

Created by

🇳🇱Netherlands johnv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024