False positives for broken links when Drupal base path is not root

juanjol → changed the visibility of the branch 1.x to hidden.

juanjol → changed the visibility of the branch 3531237-false-positives-for to hidden.

juanjol → changed the visibility of the branch 3531237-false-positives-for to active.

I just realized I haven't added tests to the MR. I'm going to generate them and add them to the issue before it's reviewed.

juanjol → changed the visibility of the branch 3531237-false-positives-for to hidden.

Now tests are added and passing.

Hello Juanjo,

Thank you for your contribution; it is really great.

However, I have some doubts regarding the point where you implemented the logic to remove the base path. Before checking the link with the "router.no_access_checks" service, we try to use other, more efficient methods to retrieve the link data—for example, by checking directly in the alias table.

Perhaps the correct place to remove the base path is when the path property is set in the Target object, specifically in the "processHrefAndSetComponents" method of the "Target" class.

This is just a question, as I am not sure what implications this change might have.

Hi lpeidro, I think the logic is in a much better place now, thanks for your suggestion! It's ready for another review.

I have made some code changes to inject the RequestStack service into the target object, following the coding standard. As a result, I also updated the unit tests.

I've tested the changes you made and everything is working as expected. I think this is ready to be set to RTBC

Automatically closed - issue fixed for 2 weeks with no activity.