- Issue created by @fjgarlin
- 🇪🇸Spain fjgarlin
Ignore the "api" module error. That's a conflict with a dependency and it's something that we are working on in the "api" queue.
- 🇬🇧United Kingdom jonathan1055
The changes look fine and all GTD branches run OK. But those phpunit jobs are still minimal. I'd like to test this on Scheduler too. I'm not expecting any problems, but better to know, given the major phpunit test discovery problems and changes in 11.2.x.
- 🇪🇸Spain fjgarlin
Yes please. I haven't been following too closely on that (really busy with other tasks) but wanted your review precisely for that. Thanks!
- 🇬🇧United Kingdom jonathan1055
Here's the full pipeline with MR372
https://git.drupalcode.org/issue/scheduler-3445052/-/pipelines/525998
The 'current' phpunit all end green, but we do get extra log messages about internal phpunit warningsAt 'next minor' - which now shows Drupal version 11.3-dev es we get the usual deprecations we have had at 11.2.x, because that's what I've set for 'next minor'
So all OK to proceed and merge, but I suggest we have a think about when to make this default-ref, i.e. not immediately.
- 🇬🇧United Kingdom jonathan1055
and just another warning - the size of the logs can massively increase with all the deprecations and internal messages. Schedulers main group now produces more than 30,000 lines of log every run.
- 🇬🇧United Kingdom catch
Is 📌 Introduce PHPUNIT_FAIL_ON_PHPUNIT_DEPRECATION Active enough to trim that back down?
- 🇬🇧United Kingdom jonathan1055
Yes partly. It removes the internal phpunit deprecations (such as core files not having new
#[ ]
attributes, but does not remove the phpunit test discovery warrnings (which are only a couple of hundred lines, so no big deal on file storage, but just makes the log long for viewing) and it does not remove any 3rd-party deprecations in test dependency modules (or which there can be lots, if you use three of four external modules for test compatibility, such as commerc, addres, token). That's where the bulk of the 30,000 lines came from. But maybe Scheduler is atypical in that way, and most contrib wont have a massive increase in log size.I tested the new behavior on #3527579-9: Add #[Group] attributes for Core 11.2 and PHPUnit 11 → and will put this into 📌 Introduce PHPUNIT_FAIL_ON_PHPUNIT_DEPRECATION Active soon.
-
fjgarlin →
committed e739566b on main
Issue #3530951 by fjgarlin, jonathan1055: Move "cuurent" to 11.2.0 and "...
-
fjgarlin →
committed e739566b on main