- Issue created by @elc
- 🇦🇺Australia elc
Update summary.
Needs a test to make sure it doesn't hit again.
- Merge request !16[#3530658] CachePluginBase::summaryTitle() must return a string. → (Merged) created by elc
- 🇦🇺Australia elc
The test-only job fails as expected.
https://git.drupalcode.org/project/views_advanced_cache/-/jobs/55894481) Drupal\Tests\views_advanced_cache\Functional\ViewsCacheMetadataTest::testCacheMetadata
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.This is a bug preventing the module from working for new uers. As such, merge and release immediately.
- 🇦🇺Australia elc
Fixing the return type hint is a more complete way to handle this. Upstream code does not have a return type but it does return a translated string. This means we should change the type hint to "string|\Stringable" so that both a plain string and a translated string can be returned.
Any string that has english words in it should be translated, which is done in this case, but the translated strings are concatenated prior to being returned.
Revert the cast, change the type hint.
- Merge request !17[#3530658] Fix type hint. Revert translatable cast to string. → (Merged) created by elc
- 🇦🇺Australia elc
Will not be ported back to 8.x-1.x as it doesn't include the type hint. Keep that cast in that branch.
Automatically closed - issue fixed for 2 weeks with no activity.