Do not inject the Settings singleton

Open on Drupal.org →

Created on 17 June 2025, 16 days ago

Problem/Motivation

It has been found that it is best to use Settings as a singleton instead of injecting it into services, see #2199795: Make the Settings class prevent serialization of actual settings →

Steps to reproduce

Proposed resolution

Do not inject settings into KeycloakService. Instead access settings directly via Settings::get().

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇨🇭Switzerland znerol

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!3Do not inject the Settings singleton
Merged
🇨🇭Switzerland znerol
updated 16 days ago

Comments & Activities

Issue created by @znerol
Merge request !3Issue #3530596: Do not inject settings, use singleton instead → (Merged) created by znerol
Comment 16 days ago →
🇨🇭Switzerland znerol
Pipeline finished with Success
16 days ago
Total: 196s
#524525
First commit to issue fork.
Pipeline finished with Skipped
16 days ago
#525257
Comment 16 days ago →
System Message

roromedia → committed ee256d12 on 1.0.x authored by znerol →
Issue #3530596 by znerol: Do not inject the Settings singleton
Comment 16 days ago →
🇦🇹Austria roromedia Linz

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024