- Issue created by @aubjr_drupal
- π¬π§United Kingdom longwave UK
hook_update_N() is not run at module install time either, so the suggested comment is not quite right.
- πΊπΈUnited States nicxvan
Oh I knew that I just misread the issue summary.
Only install, module_preinstall, modules_installed run during the installer.
Is it worth noting that update hooks run during update and not install?
- First commit to issue fork.
- Merge request !13005Issue #3530456: Added some text to module.api to explain different hooks β (Closed) created by nexusnovaz
- π¬π§United Kingdom nexusnovaz
I've made a MR (!13005), so if someone could take a look at the text i've added there, that would be great.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs work
7 days ago 12:43am 16 August 2025 - πΊπΈUnited States nicxvan
Couple of more comments sorry I missed it my first pass.
- First commit to issue fork.
- π¨π¦Canada karimb
Thanks @nicxvan for the feedback! I've updated the documentation to address your suggestions - removed the hook references and clarified the storage location.
- πΊπΈUnited States nicxvan
Thanks! One more suggestion, I think the word never and the instead in this context wasn't super clear so I modified it, you can click the apply suggestion button in the MR if you agree with my suggestion then we can get this in.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States nicxvan
This is ready!
By the way, you can apply suggestions directly from gitlab when you are logged in, you don't have to manually create those commits.
Thanks!
I took a pass at applying credit so far as well!
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!